Skip to content

only compile ExtractZIP when WITH_MINIZIP is enabled #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

only compile ExtractZIP when WITH_MINIZIP is enabled #7252

wants to merge 3 commits into from

Conversation

@christian-rauch
Copy link
Contributor

Fix compilation with WITH_MINIZIP set to OFF.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Fix compiling ExtractZIP.cpp when WITH_MINIZIP is OFF. See #7177 (comment).

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

@update-docs
Copy link

update-docs bot commented May 27, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@christian-rauch
Copy link
Contributor Author

@ssheorey Many tests fail because the log file /root/open3d_data/extract/SampleRedwoodRGBDImages/trajectory.log cannot be read. I guess this log file is compressed and cannot be read because of the missing ExtractZIP.cpp support. Should the test be disabled in this case?

@ssheorey
Copy link
Member

Hi @christian-rauch I'd prefer to just keep minizip ON all the time, to simplify the config and build process. We can just remove that option and fail the build if minizip is not available.

@christian-rauch christian-rauch force-pushed the fix_minizip branch 3 times, most recently from 21e8d04 to 1264a57 Compare June 19, 2025 09:10
@christian-rauch
Copy link
Contributor Author

@ssheorey Can you check this again? WITH_MINIZIP is now ON again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christian-rauch @ssheorey @christianrauch